A non muslim, no matter how many good deeds he has, he is a non muslim and his deeds will only benefit him in this world if he does not accept islam. As for the sinful Muslim, he will be punished for his sins if Allah doesn’t forgive him for a period of time in hell and then eventually will end up in paradise. However, if he doesn’t pray at all, he is not Muslim!